feat(qrm, sysadvisor): Periodically (every 300s) clean up excessive (>2000) dying mem cgroups#1069
Open
Zera-Algorithm wants to merge 5 commits intokubewharf:mainfrom
Open
feat(qrm, sysadvisor): Periodically (every 300s) clean up excessive (>2000) dying mem cgroups#1069Zera-Algorithm wants to merge 5 commits intokubewharf:mainfrom
Zera-Algorithm wants to merge 5 commits intokubewharf:mainfrom
Conversation
Zera-Algorithm
requested review from
cheney-lin,
luomingmeng,
sun-yuliang and
xu282934741
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
==========================================
+ Coverage 60.83% 61.08% +0.25%
==========================================
Files 739 739
Lines 69769 69912 +143
==========================================
+ Hits 42443 42705 +262
+ Misses 22567 22431 -136
- Partials 4759 4776 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JulyWindK
reviewed
Mar 16, 2026
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/plugin/memory_offloading.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/plugin/memory_offloading.go
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/plugin/memory_offloading.go
Outdated
Show resolved
Hide resolved
JulyWindK
reviewed
Mar 17, 2026
pkg/agent/sysadvisor/plugin/qosaware/resource/memory/plugin/memory_offloading_test.go
Show resolved
Hide resolved
JulyWindK
reviewed
Mar 17, 2026
JulyWindK
reviewed
Mar 18, 2026
| type QoSAwarePluginOptions struct { | ||
| SyncPeriod time.Duration | ||
| SyncPeriod time.Duration | ||
| EnableDyingMemcgReclaim bool |
Collaborator
There was a problem hiding this comment.
Would it be better to put this configuration in MemoryAdvisorOptions?
Collaborator
|
The commit needs to be squashed. |
…>2000) dying mem cgroups. BREAKING CHANGES: 1. Add a scheduled task in SysAdvisor to trigger dying memcg cleanup every 300s. 2. Add a new task in the QRM plugin to trigger dying memcg cleanup via memory reclamation using memory.reclaim.
…ommon `manager.go` interface, and using `MemoryOffloadingWithAbsolutePath` instead of self-written `invokeMemoryReclaim`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat(qrm, sysadvisor): Periodically (every 300s) clean up excessive (>2000) dying mem cgroups.
BREAKING CHANGES:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: